GSA / smartpay-training

Prototype for new GSA SmartPay training quizzes
8 stars 4 forks source link

Load final list of A/OPCs for reporting (for launch) #186

Closed A-L33 closed 9 months ago

A-L33 commented 1 year ago

Current list of authorized users may be out of date. Requires program to reach out to confirm reporting permissions. List is available: https://docs.google.com/spreadsheets/d/1OV03JTnVTDAIOQUxIzLxVnlgvBfQotRS_x5uPCNl4yk/edit#gid=0

Dependency on #340 Dependency on #354

Acceptance Criteria:

African Development Foundation Armed Forces Retirement Home Consumer Financial Protection Bureau Corporation for National and Community Service Department of Homeland Security OIG Denali Commission Executive Office of the President Farm Credit Administration Farm Credit System Insurance Corporation Federal Housing Finance Agency Federal Housing Finance Agency OIG Federal Labor Relations Authority Federal Maritime Commission Federal Mediation and Conciliation Service Federal Mine Safety and Health Review Commission Federal Trade Commission Gulf Coast Ecosystem Restoration Council Inter-American Foundation Merit Systems Protection Board National Archives & Records Administration National Endowment for the Humanities National Mediation Board Occupational Safety & Health Review Commission National Capital Planning Commission Office of Government Ethics U.S. Access Board U.S. Chemical Safety & Hazard Investigation Board U.S. Court of Appeals for Veterans Claims U.S. Election Assistance Commission U.S. Department of Housing and Urban Development U.S. Department of Housing and Urban Development OIG Consumer Product Safety Commission Privacy & Civil Liberties Oversight Board United States Tax Court

JessicaMarine1 commented 11 months ago

@A-L33 @rebekahperillo I think this was discussed, but wanted to document that for these A/OPCs, we will need to know:

1.Full name 2.Email address 3.Agency 4.Bureau (if applicable) 5.List of agencies/bureau(s) for reporting access


1-4 is to set up their profile 5 is to grant reporting access

A-L33 commented 11 months ago

That is the information we've requested from the A/OPCs. Thank you!

A-L33 commented 10 months ago

List should be finalized by COB Thursday, 9/14.

weiwang-gsa commented 10 months ago

@A-L33 Looks like the doc is not ready yet, Agencies tab seems good to me. But other tabs are not ready, we will need user full name, user email, user's agency, user's bureau, reporting_agency, reporting bureau. The first 4 column we need them in order to load them into users table, the last two, we need them to assign reporting access. Thank you!

weiwang-gsa commented 10 months ago

I will start working on agencies first.

weiwang-gsa commented 10 months ago

@A-L33 I don't see these agency names in our current agency list. Are those agencies under "Other Boards and Commissions" or "Other" ? or do we need to add new agencies? Also, there are some entries in red highlights, are these removed or still valid entries?

Image

A-L33 commented 10 months ago

For those agencies, please align them to "Other" and the reporting access should be "Other" as well. Thank you!

On Tue, Sep 19, 2023 at 9:54 AM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 I don't see these agency names in our current agency list. Are those agencies under "Other Boards and Commissions" or "Other" ? or do we need to add new agencies? Also, there are some entries in red highlights, are these removed or still valid entries?

[image: Image] https://user-images.githubusercontent.com/119954777/268974317-15595fff-b6dd-4141-ade4-07ec9801f93d.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/186#issuecomment-1725625361, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX44T5GPAAKDKENBTU3X3GPXXANCNFSM6AAAAAAX57G3MY . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 10 months ago

@A-L33 how about "Legal Services Corporation"?

Image

A-L33 commented 10 months ago

Please label as "Other."

On Tue, Sep 19, 2023 at 10:13 AM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 how about "Legal Services Corporation"?

[image: Image] https://user-images.githubusercontent.com/119954777/268986148-43800ed3-1ad7-41e9-9aee-630cdd01e7b6.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/186#issuecomment-1725690556, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX2RS33YKQDY3EVEHRDX3GSBRANCNFSM6AAAAAAX57G3MY . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 10 months ago

@A-L33 for users that has reporting agency as "Other Boards and Commissions", I assume the user's agency is also "Other Boards and Commissions" , should I mark "Little River Band of Ottawa Indians", "Wichita and Affiliated Tribes" as "Other"?

Image

For below, if I can't find left side in agency list, I assume I can replace it to the right side agency name?

Image

A-L33 commented 10 months ago

Sorry for the confusion. The "Little River Band of Ottawa Indians" should be "Native American Tribal Governments. For the Other Boards and Commissions, you are correct. Thank you!

On Tue, Sep 19, 2023 at 11:55 AM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 for users that has reporting agency as "Other Boards and Commissions", I assume the user's agency is also "Other Boards and Commissions" , should I mark "Little River Band of Ottawa Indians", "Wichita and Affiliated Tribes" as "Other"?

[image: Image] https://user-images.githubusercontent.com/119954777/269013804-2c62f962-b17f-4560-b6cc-3be0798de80d.png

For below, if I can't find left side in agency list, I assume I can replace it to the right side agency name?

[image: Image] https://user-images.githubusercontent.com/119954777/269016923-3a0d3dc7-d5a1-409f-b679-94a9c78fb976.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/186#issuecomment-1725940364, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXXZ5KUHAXDECYWCLXY3X3G6ALANCNFSM6AAAAAAX57G3MY . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 10 months ago

@A-L33 is " "Wichita and Affiliated Tribes" also "Native American Tribal Governments"?

A-L33 commented 10 months ago

Yes, it is!

On Tue, Sep 19, 2023 at 12:20 PM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 is " "Wichita and Affiliated Tribes" also "Native American Tribal Governments"?

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/186#issuecomment-1726026749, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX2KH4MPV6V534CUYHDX3HA3PANCNFSM6AAAAAAX57G3MY . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 10 months ago

@A-L33 those red highlights records has multiple agencies as user's agency, user's agency is one to one relationship, should only have one agency. report agencies can have multiple agencies.

Image

A-L33 commented 10 months ago

I fixed it! All agencies with bureau reporting should be good to go except for Treasury. We have an outstanding question with their POC, which will likely require adding at least one bureau. I'll let you know when Treasury is good, but the rest should be ready. Let me know if you have any questions!

weiwang-gsa commented 10 months ago

@A-L33 Thanks Andrew, I am finally done with agencies tab. For agencies with bureaus:

Image

Thank you~

A-L33 commented 10 months ago

@weiwang-gsa Just fixed both. Sorry about that! Still waiting for Treasury.

weiwang-gsa commented 10 months ago

@A-L33 one missing user's bureau from the Commerce tab, didn't notice it earlier, thank you!

Image

A-L33 commented 10 months ago

Fixed!

On Wed, Sep 20, 2023 at 2:09 PM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 one missing user's bureau from the Commerce tab, didn't notice it earlier, thank you!

[image: Image] https://user-images.githubusercontent.com/119954777/269378371-a1627b80-6dc1-41ee-89ef-6c350b74cea8.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/186#issuecomment-1728212582, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX5ELQZNWEXNYIJMQHTX3MWNBANCNFSM6AAAAAAX57G3MY . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 10 months ago

@A-L33 For HHS, there is no "Advanced Research Progjects Agency (ARPA-H)" bureau currently, is it the new bureau you mentioned in today's standby that needs to be added to system?

A-L33 commented 10 months ago

That's a typo from the agency that I fixed in one place but not in the other. It should be "Advanced Research Projects Agency (ARPA-H)." Just fixed it!

A-L33 commented 10 months ago

@weiwang-gsa Treasury just got back to me and asked to add "Administrative Resource Center" and "Treasury Departmental Offices" as bureaus. I think we should be good to go, I asked the A/OPC if we're missing anything else and haven't heard back. Thank you!

weiwang-gsa commented 10 months ago

@A-L33 @rebekahperillo changes are made to staging, since there is no design change involved, I move the ticket directly to ready for QA: https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/preview/gsa/smartpay-training/staging/

weiwang-gsa commented 10 months ago

@A-L33 @rebekahperillo As I mentioned in today's standby, all the preloading data are in seed.yaml file here: https://github.com/GSA/smartpay-training/blob/staging/data/seedsdata.yaml

If you search by "AOPCs:", you will see all the AOPCs data listed there.

In future, if you ever want to add new AOPC, you can add new entry following previous example:

  1. AOPC with agency without sub bureaus, format example below:

Image

  1. AOPC with agency with sub bureaus, format example below:

Image

  1. AOPC who have reporting agency with all bureaus, format example below:

Image

Please note, new entry needs to be under "AOPCs: " section. and please keep the format and indentation as previous entry, yaml file strictly follow format and indentation.

Also you will need engineer to run python script to load yaml file data into DB. Please let me know if you have any questions.

weiwang-gsa commented 10 months ago

@A-L33 @rebekahperillo I need to clean up AOPCs data on staging, please let me know if it is ok to proceed.

rebekahperillo commented 10 months ago

Sure, go ahead! :)

weiwang-gsa commented 10 months ago

@A-L33 @rebekahperillo AOPC data clean up on staging is completed, you can continue to QA.

rebekahperillo commented 10 months ago

@weiwang-gsa Overall, the QA is going very well!

It looks like only the first line for Treasury (Linda Ruppel) is in the system. The other users below are not.

You also know that the following users should not include Navy reporting: