search

GSA / smartpay-website

SmartPay website
https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
3 stars 0 forks source link

Dependabot Alert: Undici's cookie header not cleared on cross-origin redirect in fetch #402

Open JennaySDavis opened 8 months ago

JennaySDavis commented 8 months ago

Severity - Low

Impact Undici clears Authorization headers on cross-origin redirects but does not clear Cookie headers. By design, cookie headers are forbidden request headers, disallowing them to be set in RequestInit.headers in browser environments. Since Undici handles headers more liberally than the specification, there was a disconnect between the spec's assumptions and Undici's fetch implementation.

As such, this may lead to accidental leakage of cookies to a 3rd-party site or a malicious attacker who can control the redirection target (i.e., an open redirector) to leak the cookie to the 3rd party site.

Patches This was patched in e041de359221ebeae04c469e8aff4145764e6d76, which is included in version 5.26.2.

JennaySDavis commented 7 months ago

#402 Acceptance Criteria

Pass/Fail Description
Pass Smoke Testing of Program Website system

Comments/Additional Notes Performance score will increase when https://github.com/orgs/GSA/projects/43/views/1?pane=issue&itemId=46203471 is completed. A Link checker was completed on the app - no broken links.

ADA Compliance (Automated scan via Chrome Lighthouse) Criteria Score
Performance 97*
Accessibility 100
Best Practices 100

*average score of several scans completed. Details of the scans can be found in the Google Drive >Accessibility Compliance Testing

Passed 02/5/2024 - JSD

johnbeallgsa commented 7 months ago

I reviewed the program website and did not see any issues. Thank you! Moving to Done! Performance score will increase when https://github.com/orgs/GSA/projects/43/views/1?pane=issue&itemId=46203471 is completed.