search

GSA / smartpay-website

SmartPay website
https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
3 stars 0 forks source link

Convert Smart Bulletins from PDF to HTML (Smart Bulletins#29 - #38) #449

Open JennaySDavis opened 7 months ago

JennaySDavis commented 7 months ago

This is linked to the Parent story https://github.com/orgs/GSA/projects/37/views/1?pane=issue&itemId=31304335. The following Smart Bulletins have been converted from PDF to HTML: https://github.com/GSA/smartpay-website/blob/staging/public/files/smartbulletins/smart-bulletin-038.pdf https://github.com/GSA/smartpay-website/blob/staging/public/files/smartbulletins/smart-bulletin-037.pdf Smart Bulletin No. 036 Smart Bulletin No. 035 Smart Bulletin No. 034 Smart Bulletin No. 033 Smart Bulletin No. 032 Smart Bulletin No. 031 Smart Bulletin No. 030 Smart Bulletin No. 029

JennaySDavis commented 7 months ago

#419 Acceptance Criteria

Pass/Fail Description
Pass Smart Bulletin #38
Pass Smart Bulletin #37
Pass Smart Bulletin #36
Pass Smart Bulletin #35
Pass Smart Bulletin #34
Pass Smart Bulletin #33
Pass Smart Bulletin #32
Pass Smart Bulletin #31
Pass Smart Bulletin #30
Pass Smart Bulletin #29

Comments/Additional Notes Performance score will improve when the following tickets have been implemented: https://github.com/GSA/smartpay-website/issues/443 and https://github.com/GSA/smartpay-website/issues/378

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Performance Accessibility Best Practice
Smart Bulletin 38 97  100 100
Smart Bulletin 37 95 100 100
Smart Bulletin 36 96  100 100
Smart Bulletin 35 97 100 100  
Smart Bulletin 34 98  100 100  
Smart Bulletin 33 97  100 100 
Smart Bulletin 32 98 100 100 
Smart Bulletin 31 95 100 100 
Smart Bulletin 30 98 100 100  
Smart Bulletin 29 95 100 100

Passed 2/20/24- JSD

johnbeallgsa commented 7 months ago

@john-labbate On SmartBulletin 29 - can you remove this section since we no longer have an attachment? Can you also remove the trademark here? And last thing is to update the link below to Smartbulletin 33.

To assist cardholders and card managers, a list of the sources (“vendors”) of the covered telecommunications equipment and/or services is posted on the GSA SmartPay® website at https://smartpay.gsa.gov/content/prohibited-vendor-list. - update to Smartbulletin 33

Image

Image

johnbeallgsa commented 7 months ago

@john-labbate on Smartbulletin 33 this was supposed to be the correct link which reflects adding the new prohibited item of Kaspersky Lab https://docs.google.com/document/d/16Du-m6Na-R1dShHxWDliQ4ExPzK-OxNB7qP70X06WN4/edit

johnbeallgsa commented 7 months ago

Moving to Done. I appreciate all the last minutes changes! Great job!