GSMA-CPAS / BWRP-UI

Apache License 2.0
1 stars 0 forks source link

Orange - MVP Review V0.2 (unconditional, 10+ TADIG, 7 services, linear rating) #75

Closed Pad-135 closed 3 years ago

Pad-135 commented 3 years ago

Contract: 05c88a9f793f7ce27876e317d31d01088ecb13aa946842581af696c949715b41 Test - 26/4 on test dev (V0.1) Test - 27/04 - OK (V0.2) - correction in TADIG codes

Computed from the solution & expected values: Home Revenues: 9 425 552 EUR (expected - 9 436 467) Partner view: 9 491 659 EUR (exp. - 9 502 683) Partner Revenues: 11 115 642 EUR (exp. - 11 119 990) Home view: 11017131 EUR (exp. - 11 021 452

Question: In the report, charges for the outbound report are negative (because it represents costs - not used in the conditional model, only inbound is use - is it tolerated by the system ?)

Status: OK - closed.

tomSkrzekOvoo commented 3 years ago

I have fixed critical issues. The reason was error in provided contract JSON. TADIG codes were provided as single string: "AAZTR,AUTMM,AUTTR,CZERM,DEUD1,GRCCO,HRVCN,HUNH2,NLDDT,NLDPN,POL02,ROMCS,SVKET" and not as array of strings: ["AAZTR", "AUTMM", "AUTTR", "CZERM", "DEUD1", "GRCCO", "HRVCN", "HUNH2", "NLDDT", "NLDPN", "POL02", "ROMCS", "SVKET"]

I am sending fixed dataset:

20210426_PD_Test.zip

Please verify the changes

sgerhardt-trilobyte commented 3 years ago

It seems that these tadig codes were copied & pasted and not added manually. In the next version it should be possible to copy & paste tadig codes

tomSkrzekOvoo commented 3 years ago

After adding support for MOC Satellite, values calculated in Settlement Report match expectation. New version of Atomic Setup with fixes will be deployed today or tomorrow. We will notify you by e-mail image