search

GSTJ / react-native-code-push-plugin

Code Push plugin to integrate seamlessly with Expo
17 stars 4 forks source link

Prepare for standalone Code Push Server instances #10

Closed mgscreativa closed 1 week ago

mgscreativa commented 1 week ago

Hi! as described in the CP project readme it needs to have set up some config keys to set the stand alone server URL as stated here https://github.com/microsoft/code-push-server/blob/main/api/README.md#configure-react-native-code-push

So I think this plugin needs to expose those config values in order to be set up in the Expo project config

GSTJ commented 1 week ago

Hey! It should be straightforward. I won't be able to look into it this week but feel free to open a PR, and I'll review it if you can.

We can accept a serverUrl on the plugin configs and replace the plist and strings entries if there's one.

mgscreativa commented 1 week ago

Done, please double check my PR because I didn't tested it, but I think all seems right