search

GSTT-CSC / MLOps

Framework for building ML apps
GNU General Public License v3.0
9 stars 5 forks source link

Updated config_minio #35

Closed alexandertdeng closed 2 years ago

alexandertdeng commented 2 years ago

Changed config_minio to use environment variables (os.environ) instead of self.config variables

laurencejackson commented 2 years ago

Thanks for this @alexandertdeng. This is a great addition and exactly what #13 was asking for! Unfortunately, this issue has already been addressed by changes merged into develop with #29.

This is my fault, there needs to be clear instructions for new contributors which make it clear that they should work off of the develop branch as opposed to the main branch. Since the code version on develop already had the changes addressing #13 made you would have seen that it had been done already. I've raised this as issue #37. I'll need to close this PR without a merge, I'm really sorry about this!