Strange terrain generation "noise" far away from 0,0

Lithorn commented 1 year ago

/### Your GTNH Discord Username

Lithorn

Your Pack Version

2.3.2

Your Server

Personal Server

Java Version

Java 8

Type of Server

Vanilla Forge

Your Expectation

Travel the world as far as I want

The Reality

Got to about 12k from spawn and started seeing spikey land masses. Was told this is an issue that had been fixed, and is related to far chunks propagating new chunks.

Tried twice now and the same issue happens with different worlds.

Your Proposal

No clue what to propose, just making sure this is known. Pictures below. Maybe enforce a 10000 block border

/

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

wlhlm commented 1 year ago

Interesting, I just tried to recreate this in the latest nightly (2023-06-22):

create a new world
/tp @p -22800 101 -81
crash!

---- Minecraft Crash Report ----
// You're mean.

Time: 2023-06-22 22:19:10 CEST
Description: Exception while updating neighbours

java.lang.StackOverflowError
    at net.minecraft.world.World.notifyBlockOfNeighborChange(World.java:714)
    at net.minecraft.world.World.notifyBlocksOfNeighborChange(World.java:648)
    at net.minecraft.world.World.notifyBlockChange(World.java:613)
    at net.minecraft.world.World.markAndNotifyBlock(World.java:488)
    at net.minecraft.world.World.setBlock(World.java:466)
    at net.minecraft.world.World.setBlockToAir(World.java:573)
    at net.minecraft.block.BlockFalling.func_149830_m(BlockFalling.java:61)
    at net.minecraft.block.BlockFalling.updateTick(BlockFalling.java:40)
    at net.minecraft.world.WorldServer.scheduleBlockUpdateWithPriority(WorldServer.java:432)
    at net.minecraft.world.WorldServer.scheduleBlockUpdate(WorldServer.java:409)
    at net.minecraft.block.BlockFalling.onNeighborBlockChange(BlockFalling.java:33)
    at net.minecraft.world.World.notifyBlockOfNeighborChange(World.java:697)
    at net.minecraft.world.World.notifyBlocksOfNeighborChange(World.java:648)
    at net.minecraft.world.World.notifyBlockChange(World.java:613)
    at net.minecraft.world.World.markAndNotifyBlock(World.java:488)
    at net.minecraft.world.World.setBlock(World.java:466)
    at net.minecraft.world.World.setBlockToAir(World.java:573)
[...]

(cut off since it's a stack overflow)

I thought we added fixes for that a while ago in RWG...

Lithorn commented 1 year ago

My server froze once while my friend was exploring. I had no idea he had gone that far out. Became locked, and had to be force closed. Then I find out he is 20k from spawn lol.

On Thu, Jun 22, 2023 at 3:23 PM Wilhelm Schuster @.***> wrote:

Interesting, I just tried to recreate this in the latest nightly (2023-06-22):

create a new world

/tp @p -22800 101 -81

crash!

---- Minecraft Crash Report ---- // You're mean.

Time: 2023-06-22 22:19:10 CEST Description: Exception while updating neighbours

java.lang.StackOverflowError at net.minecraft.world.World.notifyBlockOfNeighborChange(World.java:714) at net.minecraft.world.World.notifyBlocksOfNeighborChange(World.java:648) at net.minecraft.world.World.notifyBlockChange(World.java:613) at net.minecraft.world.World.markAndNotifyBlock(World.java:488) at net.minecraft.world.World.setBlock(World.java:466) at net.minecraft.world.World.setBlockToAir(World.java:573) at net.minecraft.block.BlockFalling.func_149830_m(BlockFalling.java:61) at net.minecraft.block.BlockFalling.updateTick(BlockFalling.java:40) at net.minecraft.world.WorldServer.scheduleBlockUpdateWithPriority(WorldServer.java:432) at net.minecraft.world.WorldServer.scheduleBlockUpdate(WorldServer.java:409) at net.minecraft.block.BlockFalling.onNeighborBlockChange(BlockFalling.java:33) at net.minecraft.world.World.notifyBlockOfNeighborChange(World.java:697) at net.minecraft.world.World.notifyBlocksOfNeighborChange(World.java:648) at net.minecraft.world.World.notifyBlockChange(World.java:613) at net.minecraft.world.World.markAndNotifyBlock(World.java:488) at net.minecraft.world.World.setBlock(World.java:466) at net.minecraft.world.World.setBlockToAir(World.java:573) [...]

(cut off since it's a stack overflow)

I thought we added fixes for that a while ago in RWG...

— Reply to this email directly, view it on GitHub https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/13774#issuecomment-1603267827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7B6WUN7YCOZ3UAQ2JXDQTXMSSUJANCNFSM6AAAAAAZQV74BM . You are receiving this because you authored the thread.Message ID: @.***>

wlhlm commented 1 year ago

Restarting the pack, it's loading now and I can confirm the issue (in nightly as mentioned above).

2023-06-22_22 32 25 2023-06-22_22 34 03

The difference is that the pattern seems to only affect snow and ice, the underlying landmass seems to generate like normal.

Then I tried teleporting to the next Dead Swamp biome as in your screenshot (using a Nature's Compass) and I can see the same rock formations as in your screenshot. It seems like those use the same (buggy) generator as the snow and ice.

Lithorn commented 1 year ago

On my server, a lot more than snow and ice is affected. Seems to be random when I look at things. Also I get this message now when my server loads.

[Server thread/INFO] [STDOUT]: [rwg.world.RwgWorldSavedData:func_76187_b:40]: RWG SAVING DATA DATA - NOISE: UNKNOWN

Dream-Master commented 1 year ago

i remember bartworks fix that or was it bart fix it in another mod i cant remember. Wondering why it was broken again

bombcar commented 11 months ago

@Caedis did our migration of Bart's fix to RWG fix this? https://github.com/GTNewHorizons/Realistic-World-Gen/pull/13

Or maybe there's another one undetected

Caedis commented 11 months ago

The fix only kicks in past -28675 in either direction and this issue is before that so its definitely an issue with the world gen/noise

GTNewHorizons / GT-New-Horizons-Modpack