GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.02k stars 314 forks source link

[Blood Magic] BM Book does not appear in game. #15861

Open IcaroKaue opened 8 months ago

IcaroKaue commented 8 months ago

Your GTNH Discord Username

IcaroK

Your Pack Version

2.6-nightly-390

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

There have been reports of a .lang file in the BM .jar. One would expect this file to appear as a book. The book's name is Sanguine Scientem.

javaw_MzWESYKCd5 image

The Reality

The book does not appear in game. It seems that, although it was implemented in 1.12.2, it was never implemented in 1.7.

Your Proposal

Either implement the book, or remove it from the .jar file entirely. It appears that there is some stuff in the book that's not in game (due to 1.12.2 vs 1.7.10), so that would warrant axing it.

Final Checklist

kamenskyi commented 8 months ago

Sanguine Scientiem is a item from [Guide API]. so that there is a book. I probably need this mod

IcaroKaue commented 8 months ago

I have found its github, luckily it has the MIT license. Though we still need to check if the book is accurate to the 1.7.10 version.

kamenskyi commented 8 months ago

found it here https://ru-minecraft.ru/mody-minecraft/49131-guideapi.html

kamenskyi commented 8 months ago

you need to check if the book will appear when adding the mod

IcaroKaue commented 8 months ago

Adding Guide-API adds the books, but they're glitchy.

javaw_1UOTVXayGm javaw_rL04n0b9Yj AsPowerBar_S9nIIEOiAQ

kamenskyi commented 8 months ago

Then these are questions for the moderators. Maybe they will find a mistake and fix it

IcaroKaue commented 8 months ago

Then these are questions for the moderators. Maybe they will find a mistake and fix it

I see. For the time being, we don't translate these right? Since it takes up ~60k words.

Alastors commented 8 months ago

We will not resolve this issue. If we leave the book, we need to mod this and solve display problems. If we don’t add it, we leave it as is. let the modders decide. It’s too early to translate the book yet. you have to decide whether to keep the book or not

Who won’t resolve this issue? I presume you aren’t talking about the GTNH dev team

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

kamenskyi commented 2 months ago

@Alastors @Dream-Master the book works great. only need a stable version. here are screenshots from the game https://github.com/TeamAmeriFrance/Guide-API/tree/1.7.10 https://www.curseforge.com/minecraft/mc-mods/guide-api stable version - https://www.curseforge.com/minecraft/mc-mods/guide-api/files/2241379 2024-09-27_01 31 33 2024-09-27_01 31 35 2024-09-27_01 31 38 2024-09-27_01 31 40 2024-09-27_01 31 51 2024-09-27_01 31 52 2024-09-27_01 31 54 2024-09-27_01 31 56 2024-09-27_01 31 57 2024-09-27_01 31 59 2024-09-27_01 32 05 2024-09-27_01 32 08 2024-09-27_01 32 09 2024-09-27_01 32 10 2024-09-27_01 32 45 2024-09-27_01 32 46 2024-09-27_01 33 02 2024-09-27_01 33 35 2024-09-27_01 33 38 2024-09-27_01 34 01 2024-09-27_01 34 24 2024-09-27_01 34 33

Alastors commented 2 months ago

Nice

kamenskyi commented 2 months ago

6666

chochem commented 2 months ago

since the book is not particularly relevant/accurate for gtnh, why would we add a mod to the pack just to make it work?