GUDHI / gudhi-devel

The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
https://gudhi.inria.fr/
MIT License
259 stars 66 forks source link

protected vs private (Simplex_tree) #1146

Open mglisse opened 1 month ago

mglisse commented 1 month ago

In the Simplex_tree, many types, functions and members are marked private. I wonder if we should mark some of them protected instead. The effect would be the same for someone using the Simplex_tree directly, but it would give advanced users (and possibly ourselves?) a chance to implement additional functions in a derived class, which may be quite hard using only the public interface. That doesn't mean that undocumented private details would become stable interfaces though, anyone using them would still have to check with each release if things still work.