search

GalacticDynamics / unxt

Unitful Quantities in JAX
https://unxt.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 3 forks source link

fix: comparison ops #245

Closed nstarman closed 3 weeks ago

nstarman commented 1 month ago

Fixes #244

nstarman commented 1 month ago

The block_until_ready error appears to be unrelated. But it would be good to solve. I'm not getting it on my machine.

nstarman commented 1 month ago

Apparently it is related #246 isn't triggering it.

nstarman commented 1 month ago

Found it. It's the new version of equinox. 0.11.8.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (e2e5723) to head (8e14140). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/unxt/_src/quantity/register_primitives.py 94.87% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ========================================== + Coverage 95.84% 96.28% +0.43% ========================================== Files 42 42 Lines 1541 1479 -62 ========================================== - Hits 1477 1424 -53 + Misses 64 55 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nstarman commented 1 month ago

@adrn should be ready to review

nstarman commented 1 month ago

I actually need to cut a release. This can be a bugfix release to follow up.