`SwapOperations` Swap Fees may add up to more than 100%

GalloDaSballo / Apollon-Review

Notes for the Apollon Solo Security Review

0 stars 0 forks source link

Open GalloDaSballo opened 3 months ago

GalloDaSballo commented 3 months ago

swapBaseFee is capped to 1e18, but it is added to Pair.getSwapFee meaning that it may result in a value higher than 100%

Cap fees at a smaller value, such as at most 10%

sambP commented 3 months ago