GalloDaSballo / Apollon-Review

Notes for the Apollon Solo Security Review
0 stars 0 forks source link

`LiquidationOperations` loop should `break` on last Trove #74

Open GalloDaSballo opened 3 months ago

GalloDaSballo commented 3 months ago

Impact

Apollon will not liquidate the last trove in batchLiquidateTroves However, the code is using a continue which means that the code will loop multiple times while performing no-ops

     if (troveManager.getTroveOwnersCount() <= 1) continue; // don't liquidate if last trove

Mitigation

Change the code to

      if (troveManager.getTroveOwnersCount() <= 1) break; // no more troves to liquidate
sambP commented 3 months ago
Screenshot 2024-08-27 at 6 51 45 PM