search

Galooshi / import-js

A tool to simplify importing JS modules
MIT License
524 stars 70 forks source link

594 move to prettier abandon eslint #598

Closed mikabytes closed 7 months ago

mikabytes commented 7 months ago

I have separated this work into 4 commits. You may want to review them separately, as otherwise prettier is making too much noise to see what is actually going on.

First make the necessary changes for prettier to start working, and eslint to stop working.

Second and third deals with four files that were improperly formatted. They didn't have the // @flow shebang, so tests didn't find the issues that they had. But prettier found it! So I added the shebang where I could, and removed the Flow code where there were errors.

Fourth is the actual run of prettier.

Very pretty.

trotzig commented 7 months ago

Ignore the codeclimate status. I'm trying to get that set up again and will need some time to tweak.

trotzig commented 7 months ago

LGTM!

mikabytes commented 7 months ago

Hey @lencioni I'd love to have your feedback as well. Does all this look good to you?

Also a question, for this project, is it typically the reviewer who makes the merge, or the requester?

trotzig commented 7 months ago

I would say Requester, but it's not important who does it. Go ahead and merge when you feel ready.

(@lencioni is located in the US so probably won't check this for a few hours).

mikabytes commented 7 months ago

Alright, thanks.

I need to switch focus to another project now, so no rush on my side getting this merged

trotzig commented 7 months ago

Sorry if I messed up a clean merge here. Should be fairly straightforward to rebase this on the latest master. I've changed some lines that you can apply my version of. Then just run prettier on the whole thing again. 🙏

mikabytes commented 7 months ago

Sorry if I messed up a clean merge here.

No worries at all. I thought that would happen, which is partly why I cleanly separated the prettier run in a single commit so that I may change it later :+1:

mikabytes commented 7 months ago

Merged this as we agreed to keep the semis and move to single quotes and there were no other concerns. But I realized maybe @lencioni wanted to review an extra time? If so, sorry! We can revert.