Gapminder / ddf-validation

How do you know your DDF dataset is ✅valid?
https://open-numbers.github.io/ddftools.html
GNU General Public License v3.0
7 stars 2 forks source link

indicator missing in datapackage.json #449

Closed semio closed 7 years ago

semio commented 7 years ago

dataset: https://github.com/harpalshergill/ddf--unpop--wpp_population ddf-validation: 1.8.0

there is an indicator ddf--datapoints--dependencyratio1564--by--country--year--variant: https://github.com/harpalshergill/ddf--unpop--wpp_population/tree/master/ddf--datapoints--dependencyratio1564--by--country--year--variant

But this indicator is not in datapackage.json, which is generated by ddf-validation. Not sure if there are more missing indicators. Please check.

buchslava commented 7 years ago

@semio Are you sure that latest version (1.8.0) was used or datapackage.json was recreated after repository's changing? I just created datapackage.json via 1.8.0 and:

screenshot from 2017-07-24 15-03-21

screenshot from 2017-07-24 15-02-42

semio commented 7 years ago

oh, sorry I didn't confirm with Harpal. So possibly Harpal is using an old version.

buchslava commented 7 years ago

@semio ok, cool, please close the issue when you will be ready

semio commented 7 years ago

ok, close