Gapminder / gapminder-ai

0 stars 0 forks source link

Initial project boilerplate, including linting, tests, local configuration setup, app logging config, service account authoritization and exploration notebook #1

Closed motin closed 1 year ago

motin commented 1 year ago

Initial project boilerplate, including linting, tests, local configuration setup, app logging config, service account authoritization and exploration notebook.

This should enable @semio to get set up with a local notebook configured with proper service account credentials for access to spreadsheets.

motin commented 1 year ago

Including review comment:

I think it looks good overall, I just have one question, in automation-api/.gitignore why ignore *.ipynb notebook files?

Good question. Answer: Because jupytext is configured to save a .py file for each notebook, which can be diffed and reviewed. Ipynb files are messy json files

semio commented 1 year ago

@motin I have an other question, why targeting 3.9 in the project? Is there any lib that didn't work in 3.10+? Just curious

for example we will have some benefits using 3.11

motin commented 1 year ago

@motin I have an other question, why targeting 3.9 in the project? Is there any lib that didn't work in 3.10+? Just curious

for example we will have some benefits using 3.11

* [performance](https://www.phoronix.com/review/python-311-performance)

* [new pattern matching syntax](https://peps.python.org/pep-0636/)

Good question again :) For now it is just to stay consistent with other python projects / repos in the org, but I can definitely see us upgrading sometime soon. Usually this comes with some discomfort / incompatible libs but it could definitely be worth it.

semio commented 1 year ago

thanks! now I understand. We can do the upgrade when we have time