search

GarageGames / Torque3D

MIT Licensed Open Source version of Torque 3D from GarageGames
http://torque3d.org
MIT License
3.35k stars 1.2k forks source link

corrects a copy-corruption flaw with GuiSwatchButtonCtrl::onMouseDragged #2305

Closed Azaezel closed 5 years ago

Azaezel commented 5 years ago

pretty sure the offending leak-line creeps in with https://github.com/GarageGames/Torque3D/blob/561f010f2e6411d8253d23f0cfcff794e81f60bf/Templates/BaseGame/game/tools/base/utils/swatchButtons.ed.cs#L34 comparative release/debug results in string gridBitmap = "\c0" vs string gridBitmap = "ic\c1Gl\c0" and the relavent initpersistfields entry of TypeString points to https://github.com/GarageGames/Torque3D/blob/561f010f2e6411d8253d23f0cfcff794e81f60bf/Engine/source/console/consoleTypes.h#L71 which is likely causing malformation

Azaezel commented 5 years ago

as a followup, if folks want to preemptively eyeball similar initpersistfields entries along the same lines, a list based on a wip-branch can be found https://gist.github.com/Azaezel/617204d2ffef388a2dd63ed849fd5466 , otherwise we'll deal with it on a case by case basis