Garhoogin / NitroPaint

General Purpose DS Sprite, BG, and Texture Editor
BSD 2-Clause "Simplified" License
58 stars 5 forks source link

Resize image seems to have all sorts of missing features/bugs #17

Open EchoSpaceZ opened 2 months ago

EchoSpaceZ commented 2 months ago

image_2024-07-26_144228476 There multiple files that if they are longer than the width by a large amount they don't have appropriate width options. If I try resizing it then this happens image_2024-07-26_151004974 or if i try to change the width to something think it is. image it just messes the ratio up entirely and the only way to undo it, closing it and reopening. But the problem here is I can really "resize it" properly.

Garhoogin commented 2 months ago

Hmm yeah, that doesn't look like that was supposed to happen. Changing the width and height in the character editor shouldn't have a visual effect on what's shown in the screen editor. As for the weird options it gave for the width, it's simply listing factors of the character count stored in the file. This is a restriction I also would like to remove to allow for arbitrary selections there. Thank you for taking the time to leave feedback, and I can update this thread when I have more information/updates.

EchoSpaceZ commented 2 months ago

Hmm yeah, that doesn't look like that was supposed to happen. Changing the width and height in the character editor shouldn't have a visual effect on what's shown in the screen editor. As for the weird options it gave for the width, it's simply listing factors of the character count stored in the file. This is a restriction I also would like to remove to allow for arbitrary selections there. Thank you for taking the time to leave feedback, and I can update this thread when I have more information/updates.

Hey any update on this? It's just hurting my project at the moment since I can't import anything properly yet.

EchoSpaceZ commented 1 month ago

Hmm yeah, that doesn't look like that was supposed to happen. Changing the width and height in the character editor shouldn't have a visual effect on what's shown in the screen editor. As for the weird options it gave for the width, it's simply listing factors of the character count stored in the file. This is a restriction I also would like to remove to allow for arbitrary selections there. Thank you for taking the time to leave feedback, and I can update this thread when I have more information/updates.

My buddy here says this is a problem that could be occurring do you think this is what the problem may be? image_2024-08-17_193853139

Garhoogin commented 1 month ago

Sorry I haven't had much time to work on this lately, but I may in the coming days. If you did have some sample files, that would be much appreciated.

As for the messages you show, it looks like you're describing the concept of a BG screen. Either way it doesn't appear to have rendered correctly in the editor. Thanks for bearing with me so far though :)

EchoSpaceZ commented 1 month ago

Got it- here you go

Here some examples that I know don't display right (width has no good options to import anything) and screen issue The following file will contain a combo text and ofc you just open it and search any of the following images in this list in the combo text:

  1. BG_RV_REVIVE
  2. reviver_position00
  3. btl_info_panel
  4. revive_sonota__bg

After importing an image you will see the screen tearing occur.

use this google drive link for the files

https://drive.google.com/drive/folders/1RbHOoKMCagw7r8E52PQTg1TVSPkT22BC?usp=sharing

Sorry I haven't had much time to work on this lately, but I may in the coming days. If you did have some sample files, that would be much appreciated.

As for the messages you show, it looks like you're describing the concept of a BG screen. Either way it doesn't appear to have rendered correctly in the editor. Thanks for bearing with me so far though :)

EchoSpaceZ commented 1 month ago

Are you going to take a look soon?... :/

Garhoogin commented 3 weeks ago

I can take a look at things this weekend now that I have a little more time to work on this.

Garhoogin commented 3 weeks ago

Looking more closely at the issue you're reporting, I note that:

If this indeed does line up with what you're experiencing in the editor, what exactly is it that you're trying to do?

EchoSpaceZ commented 2 weeks ago

https://github.com/user-attachments/assets/d7d7fd3a-bc48-4d05-87a7-62a05d8bd13f

This video right here should show the problem i'm having. I'm unable to import an image (the image is the correct width and height) I've try'd resizing as well. Other friends of mine have tried importing on certain images and they have the same problem it doesnt display correctly and so the import of the image cant be correct, just like the video.

(Sorry for the late response college exams were in my way)

Garhoogin commented 2 weeks ago

It's alright, I've been a bit busy myself lately as well.

Based on the video I'm assuming you want to import a new image over the one you're showing? In that case I recommend using the BG generator, since this appears to be a background utilizing character compression, which doesn't lend well to in-place editing, at least not very easily. If you go to File->New->New BG, you should get a dialog to input conversion parameters. You might be able to just leave them as-is, and then save the generated NCLR, NCGR, and NSCR over the ones in the combo you've identified. That's generally going to be the cleanest way to replace backgrounds such as these.

if you must use the character editor to import the image, since this is a background utilizing character compression, you should do the import in the screen editor window (NSCR). This imports the image as it would appear as a complete background. It will handle the character compression details automatically there. It will automatically select the correct character count based on the size of the NCGR, and you'll want to check the "Overwrite Character Indices" checkbox. This will get you essentially the same output as you would get by using the BG generator.

EchoSpaceZ commented 2 weeks ago

https://github.com/user-attachments/assets/06e9dc9d-056d-4248-9262-22f41973b1fb

So this video might explain the issues i just had with the methods you jusst recommended. Hope you can get back to me soon. I wish there was a video tutorial for all this stuff.

EchoSpaceZ commented 2 weeks ago

Ok I figured out Method #1 but i do think method #2 is much easier can you show me how to import or create a new pallete as desired in the video?

Garhoogin commented 2 weeks ago

Untitled.video.-.Made.with.Clipchamp.1.mp4

So this video might explain the issues i just had with the methods you jusst recommended. Hope you can get back to me soon. I wish there was a video tutorial for all this stuff.

Ah, in the video I see the colors messed up. The import window does not currently set the palette size to the size of palette if it's smaller than the max size (it's assuming 256 colors here). You should see those color issues fixed by putting the correct color count in that field. That's something that I can fix, making sure this is automatically set correctly.

As for only saving an NCGR, did you try pressing Ctrl+Shift+S (File->Save All)? That should save all open viewers, so the NCLR and NSCR should also save then.

I don't have any video tutorials for anything unfortunately, since there would be a lot to cover and a lot can vary depending on what you're trying to do exactly. One of the past versions I attached a user guide with it, but I haven't updated this much recently. A lot of it should still be applicable, though.

EchoSpaceZ commented 1 week ago

Is there a way for me to use the update you did to fix this? the update for release was 2.9 but that was 2 weeks ago it says you updated it like 2-3 days ago. but its not a .exe.