[Bug] RGBA128.Parser Unit Tests Failing - Githubissues

GaryHuan9 / Echo

An awesome ray traced 3D renderer build in C# from scratch!

MIT License

17 stars 3 forks source link

[Bug] RGBA128.Parser Unit Tests Failing #15

Closed GaryHuan9 closed 2 years ago

GaryHuan9 commented 2 years ago

Describe the bug RGBA128.Parse and RGBA128.TryParse unit tests failing on edge cases.

To Reproduce Steps to reproduce the behavior:

Run the unit tests.
See the errors.

Expected behavior

hdr(123, 45, 67, 89,) and hdr(-12, 3, 4) should fail.
rgb(1, 2, 3, 4.5) and rgb(-12, 3, 4) should fail.
hdr(.10, .001, .102) should pass with the expected value equalingnew RGBA128(0.1, 0.001, 0.102, 1)

Systems

OS: Windows 10
Hardware: AMD Ryzen 9 3900X
Version or Commit: 49b6f3d729b817f2d90f404d1bb594645852a990

Additional context Add any other context about the problem here.

ClemensU42 commented 2 years ago

fixed bugs in commit 8e3a045