search

Gasman2014 / KiCad-Diff

Scripts for performing image diffs between pcbnew layout revisions
MIT License
240 stars 40 forks source link

Add support to compare local not committed changes #60

Closed leoheck closed 3 years ago

leoheck commented 3 years ago

This PR adds the current local changes in the commits list allowing it to be compared without having to commit changes.

In this way, the .kicad_pcb is being added on top of the lists image

This also fixes an issue we created on fossil when removing the space_escape workaround. @jnavila

This PR was tested with Git and Fossil, unfortunately, I don't have SVN setup anymore to test.

Gasman2014 commented 3 years ago

That looks good! I will see if I can spin up an SVN repo - I did have one somewhere - but Ill go ahead and merge this. Thanks for the contribution.

leoheck commented 3 years ago

I can test it too, but I just have to restore a small svn server here. I change computers too often I guess haha.

-- Leandro Heck

On Sun, Jun 27, 2021 at 7:38 AM John @.***> wrote:

That looks good! I will see if I can spin up an SVN repo - I did have one somewhere - but Ill go ahead and merge this. Thanks for the contribution.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gasman2014/KiCad-Diff/pull/60#issuecomment-869140051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJX7YETYHA43TJJUT4HVVTTU35Q3ANCNFSM47K5KBGQ .

leoheck commented 3 years ago

I could test this with SVN. It is working as expected.

Gasman2014 commented 3 years ago

Thanks for confirming.