GateNLP / python-gatenlp

Python text processing, pattern matching, and NLP framework
https://gatenlp.github.io/python-gatenlp/
Apache License 2.0
63 stars 8 forks source link

Add annotation types parameter #183

Closed paulbriton closed 2 years ago

paulbriton commented 2 years ago

This change reflects the changes in the GATE Python Plugin to support the GATE inline XML output. Check this PR for more details.

johann-petrak commented 2 years ago

Thank you very much for that PR.

First off, I am not sure if

Could I please ask you to:

Let me know what you think of those changes.

Sorry for those additional points, we usually recommend to discuss planned changes in an issue first and then agree on how to implement the solution.

paulbriton commented 2 years ago

Thank you very much for your quick answer! I'm sorry that I didn't open an issue first to discuss these changes... To be honest, I'm currently using this in a project and I was tweaking a fork of the lib. Once I got it working locally I realized it would be better for my project if these changes were merged in the official repo.

I'll integrate the suggested changes and get back to you!

paulbriton commented 2 years ago

I've pushed the modifications. Let me know if these changes match what you had in mind!

johann-petrak commented 2 years ago

I have merged this, but there are still issues. I will try to find the time to fix them, probably faster than going back and forth here.

paulbriton commented 2 years ago

Thanks again, let me know when you'll have the time to fix the remaining issues and to make a new release!

johann-petrak commented 2 years ago

This is now implemented in the development versions of gateplugin-Python and gatenlp

Behavior has changed so that inline_anntypes=None will export ALL types from the set, while inline_anntypes=[] will export none so it is easy to choose any set.