search

GateNLP / python-gatenlp

Python text processing, pattern matching, and NLP framework
https://gatenlp.github.io/python-gatenlp/
Apache License 2.0
63 stars 8 forks source link

is.success() double call on these lines errors #189

Closed nicksunderland closed 1 year ago

nicksunderland commented 1 year ago

https://github.com/GateNLP/python-gatenlp/blob/2f8c14626af592b27d976587b6265258be7b9d0a/gatenlp/pam/pampac/pampac_parsers.py#L742

fix: ret = self.parser.parse(location, context) #.issuccess()

??

johann-petrak commented 1 year ago

That looks like a typo, thanks. Demonstrates, that we need way more unit tests for the pampac code!

johann-petrak commented 1 year ago

Fixed on branch main