GatherPress / gatherpress

Powering our community's event management needs.
GNU General Public License v2.0
61 stars 24 forks source link

Explore comment-blocks for RSVPs #696

Open carstingaxion opened 2 weeks ago

carstingaxion commented 2 weeks ago

Is your enhancement related to a problem? Please describe.

With the goal set, to transform RSVPs into regular comments (#687), GatherPress might be able to re-use some of the core/comments… blocks, as block-variations to archive the needed RSVP functionality.

This issue is meant as a first collection of related Infos:

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

carstingaxion commented 1 week ago

Congratulations @mauteri for finishing #692 (and #687) !

Based on your working branch I made some tests using the core/comment(s-...) blocks in combination with a pre_get_comments filter. This allowed me to use the default blocks with the new created RSVPs, which was nice.

grafik

I went on testing, added more interactivity to new variations of the core comments blocks one-by-one, which progressed nice & slowly, but it felt not correct, because this was far out of the GatherPress scope. A little more research proved me right: There was already & still is, an open PR adding this and more, core interactivity to the comment blocks.

Take a look at this amazing screencast (taken from the PR) and imagine, GatherPress could just create some block-variation and restrict the use to the new RSVP comment_type, like I did in my non-interactive beginning.

https://private-user-images.githubusercontent.com/3305402/261024665-bc8a6fdd-2e72-467c-9ef5-da8c99672b81.mp4?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkyMDI5MjEsIm5iZiI6MTcxOTIwMjYyMSwicGF0aCI6Ii8zMzA1NDAyLzI2MTAyNDY2NS1iYzhhNmZkZC0yZTcyLTQ2N2MtOWVmNS1kYThjOTk2NzJiODEubXA0P1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDQxNzAxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2VmYWQyN2UyNWI3MGY1YjUwNmNlM2Y3MTVjMmE4NDVlZGUxNjNlMDk2NGE1YzJmY2JkMGVhYWQxM2YwZjA3MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.1XY7qotkpcMYjNjdKpOOZ3gDd-kQa137HDNAlrmICTc

This would be .... Wow! I think.

And it would allow GatherPress' RSVPs to benefit from all of the built-in and plugin-powered spam-protection and (some of) the core Discussion settings.