Closed Lancasterwu closed 5 years ago
Refactored compatibility()
:
preferences
-> objective_weights
to avoid confusionI think this PR should be merged then we can work on the test case, documentation and refactoring in a new branch.
New feature added to optionally use student preferences as a scalar multiple on the compatibility scores. A command line interface for preferences can be implemented either in this PR or a new one, depending on how soon we want to merge this.
Description of Pull Request
Fixes #190 Fixes #234
Type of Change
This PR is the second step of fixing issue #190, after PR#229 and before the testing and documentation. The following changes have been made:
parse_argument.py
in order to recognize new command:--graph
, which runs the graph algorithm grouping.gatorgrouper_cli.py
to allow run the command and get the output of graph algorithm grouping.read_student_file.py
to make it be able to accept float input and generate it to the list of list which contains float. Fixes issue 234conftest.py
which allow developer to write test case with temporary csv file that contains float. One is the csv that has header, another one is the csv that does not have header.read_student_file.py
to test if the float input can be handled properly.group_graph.py
in order to use the matching input that other files passing in, and the matching output that can be passed to other file.Note that implementing Graph Algorithm Grouping Method with CLI is not completed, the test case for
group_graph.py
and the documentation are still missing. In order to match the output and input there are some really bad designs ingroup_graph.py
which also need to be refactored.Please describe the pull request as one of the following:
Tags
@GatorEducator/team-lancaster should be responsible to provide documentation and test case for this ASAP. Please contact me @aubreypc @paladp @huangs1 if you find any bug.