GatorIncubator / gatorgrouper

:busts_in_silhouette: Automated Group Formation Tool Enabling Effective Team Work
GNU General Public License v3.0
20 stars 20 forks source link

Implement Graph Algorithm Grouping Method with CLI #240

Closed Lancasterwu closed 5 years ago

Lancasterwu commented 5 years ago

Description of Pull Request

Fixes #190 Fixes #234

Type of Change

This PR is the second step of fixing issue #190, after PR#229 and before the testing and documentation. The following changes have been made:

Note that implementing Graph Algorithm Grouping Method with CLI is not completed, the test case for group_graph.py and the documentation are still missing. In order to match the output and input there are some really bad designs in group_graph.py which also need to be refactored.

Please describe the pull request as one of the following:

Tags

@GatorEducator/team-lancaster should be responsible to provide documentation and test case for this ASAP. Please contact me @aubreypc @paladp @huangs1 if you find any bug.

aubreypc commented 5 years ago

Refactored compatibility():

Lancasterwu commented 5 years ago

I think this PR should be merged then we can work on the test case, documentation and refactoring in a new branch.

aubreypc commented 5 years ago

New feature added to optionally use student preferences as a scalar multiple on the compatibility scores. A command line interface for preferences can be implemented either in this PR or a new one, depending on how soon we want to merge this.