Error in Embroider enabled apps using `@tagName` with `<Menu>`

roomman commented 3 years ago

I hit up against this Embroider bug today, while trying to add some LinkTo components as menu items, using @tagName.

I see Missing component: link-to in... in the console.

I just updated to the latest Embroider modules and this is still an unresolved issue. I thought I'd add something here so we can keep track. 👍🏻

alexlafroscia commented 3 years ago

Hey @roomman -- are you able to provide a minimal reproduction for this, or give me some steps I could follow to reproduce it myself?

I would say we do not support Embroider until #93 lands; the failures there don't appear to be due to anything in this addon, but until we're running the tests against Embroider, I would say that bugs related to it aren't super high-priority

roomman commented 3 years ago

Hey @alexlafroscia, sorry for the delay in coming back on this.

Minimal reproduction can be found here. I've added individual commits, as follows:

The first simply installs this addon and renders a menu with one item, which is a link-to. When the user clicks they transition to the route.
The second represents the most basic setup for enabling Embroider, with no options. The menu behaves as expected.
The third adds all Embroider options. Crucially (I stepped through, adding each of the options in turn), the staticComponents option breaks the build with the following error:
```
Build Error (PackagerRunner) in templates/application.hbs
```

Module Error (from ../../../../../../../../Users/simon/Sites/ember-headlessui-linkto-bug/node_modules/thread-loader/dist/cjs.js): Missing component: link-to in templates/application.hbs


I'll keep an eye on [the existing bug report](https://github.com/embroider-build/embroider/issues/815) and close this once it's resolved and the build succeeds.

bertdeblock commented 2 years ago

This was fixed in v0.48.0 of @embroider/compat: https://github.com/embroider-build/embroider/blob/master/CHANGELOG.md#v0480-2021-12-07

I checked out the reproduction and bumped the embroider versions to latest and everything works fine now.

roomman commented 2 years ago

Awesome, thanks @bertdeblock, I'll close this issue.

GavinJoyce / ember-headlessui

Error in Embroider enabled apps using `@tagName` with `<Menu>` #105