Add PopperJS primitive - Githubissues

GavinJoyce / ember-headlessui

https://gavinjoyce.github.io/ember-headlessui/

Other

92 stars 34 forks source link

Add PopperJS primitive #87

Closed NullVoxPopuli closed 3 years ago

NullVoxPopuli commented 3 years ago

[ ] Needs TypeScript
[ ] Needs @popperjs/core
[ ] Needs a function-modifier implementation
[ ] Requires at least Ember 3.25

Copied from here Example usage here

GavinJoyce commented 3 years ago

Does headlessui have a popper primitive? I seem to remember that they used it in their examples alright, but I don't recall it being part of the library.

Here's one place in the docs where they mention optionally using popper:

https://headlessui.dev/react/popover#positioning-the-panel

NullVoxPopuli commented 3 years ago

I mean, I can make a separate ember popper library, which is what they done for react to get those hooks. It's impossible to use pepper directly without a bunch of boilerplate

GavinJoyce commented 3 years ago

Sorry, I wasn't clear.

Does headlessui include popper as a dependency? AFIAK, they don't - they just give an example of how to use it in their samples.

NullVoxPopuli commented 3 years ago

ah yes! I got you now -- yes that's what I observed as well.

I added this PR because I saw we wanted a Menu + Popper demo. So, we'll do the same? just include popper in the demos?

GavinJoyce commented 3 years ago

Sounds great, thanks