Gbuomprisco / ngx-chips

Tag Input component for Angular
MIT License
899 stars 359 forks source link

Angular 9 Ivy Issues #911

Open danielehrhardt opened 4 years ago

danielehrhardt commented 4 years ago

I'm submitting a ... (check one with "x")

[* ] bug report => search github for a similar issue or PR before submitting
[ ] support request/question

Notice: feature requests will be ignored, submit a PR if you'd like

Current behavior

Issue when run npm run start with Ivy enabled

ERROR in No suitable injection token for parameter 'element' of class 'Ng2DropdownButton'.
no type or decorator

Expected behavior

No Issues

Minimal reproduction of the problem with instructions (if applicable) Download Angular 9 RC0, enable Ivy and install ngx chips

What do you use to build your app?. Please specify the version

Angular CLI

Angular version:

Angular 9 RC 0

ngx-chips version:

2.1.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

gwenaellarmet commented 4 years ago

Hello, Any news on this issue ? the library is not Angular 9 friendly

rtpHarry commented 4 years ago

Just found this doesn't work after upgrading my project :(

Angular 9 is out properly now.

Gbuomprisco commented 4 years ago

I'm not sure what that could be, the error is pointing to ElemntRef being injected into a Component, which is perfectly fine.

Can you guys paste your `ng -v' here?

rtpHarry commented 4 years ago

Hmm, it was a client project so I rolled it back to Angular 8.

I didn't actually get any errors though, just the warning about peer dependencies.

I still have that window open actually:

npm WARN ngx-chips@2.1.0 requires a peer of @angular/animations@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-chips@2.1.0 requires a peer of @angular/common@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-chips@2.1.0 requires a peer of @angular/core@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-chips@2.1.0 requires a peer of @angular/forms@^8.0.0 but none is installed. You must install peer dependencies yourself.
ecappa commented 4 years ago

Same problem here, but in v8 - with Ivy enabled. (which is enabled by default in v9 - I had the exact same issue in v9).

Angular CLI: 8.3.25

Node: 13.1.0 OS: darwin x64 Angular: 8.2.14 ... animations, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... router

Package Version

@angular-devkit/architect 0.803.25 @angular-devkit/build-angular 0.803.25 @angular-devkit/build-optimizer 0.803.25 @angular-devkit/build-webpack 0.803.25 @angular-devkit/core 8.3.25 @angular-devkit/schematics 8.3.25 @angular/cdk 8.2.3 @angular/cli 8.3.25 @angular/flex-layout 8.0.0-beta.26 @angular/material 8.2.3 @angular/material-moment-adapter 8.1.1 @ngtools/webpack 8.3.25 @schematics/angular 8.3.25 @schematics/update 0.803.25 rxjs 6.4.0 typescript 3.5.3 webpack 4.39.2

chan-dev commented 4 years ago

any updates about Angular 9 compatibility?

TheRanaEhtisham commented 4 years ago

i am upgrading angular version from 5.2 to 9 and having issue Package "ngx-chips" has an incompatible peer dependency to "@angular/common" (requires "^8.0.0" (extended), would install "6.1.10"). Package "ngx-chips" has an incompatible peer dependency to "@angular/animations" (requires "^8.0.0" (extended), would install "6.1.10").uld install "6.1.10"). stall "6.1.10"). Package "ngx-chips" has an incompatible peer dependency to "@angular/core" (requires "^8.0.0" (extended), would innstall "6.1.10").stall "6.1.10").

anybody help please

SergioSuarezDev commented 4 years ago

same here with ngx chips

Celebes commented 4 years ago

I have this error on jHipster with Angular 9:

ERROR in node_modules/ngx-chips/tag-input.module.d.ts:2:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.

This likely means that the library (ngx-chips) which declares TagInputModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

2 export declare class TagInputModule {

raharrison commented 4 years ago

Unfortunately think this lib is pretty much dead at this point.. anyone have any alternatives?

Celebes commented 4 years ago

Unfortunately think this lib is pretty much dead at this point.. anyone have any alternatives?

@raharrison I've found this: https://github.com/ng-select/ng-select

Works very good so far.