GeekMagicClock / smalltv-pro

PRO version of GeekMagic smalltv
93 stars 11 forks source link

Wrong time in UK #8

Open okeeffm opened 9 months ago

okeeffm commented 9 months ago

The weather station mode reports the correct time as I assume you’re getting the time stamp and weather info from the location based weather APIs. This takes into account daylight saving (clocks going forward/backward etc) which we have in the U.K. However, in the Clock Mode, the time is incorrect (an hour ahead for example at this time of year). I assume you getting it straight from NTP servers without modification.

Maybe just use the time code you use from location based weather mode in the Time mode as a simple solution.

Also, in the Time Mode, the seconds ring, 0-60 seconds, starts at the bottom (6-o’clock position) and works it’s way round 360deg! This is a bit odd! Should really start at the 12-o’clock position? Maybe this is normal in Australia ? Lol

GeekMagicClock commented 8 months ago

The weather station mode reports the correct time as I assume you’re getting the time stamp and weather info from the location based weather APIs. This takes into account daylight saving (clocks going forward/backward etc) which we have in the U.K. However, in the Clock Mode, the time is incorrect (an hour ahead for example at this time of year). I assume you getting it straight from NTP servers without modification.

Maybe just use the time code you use from location based weather mode in the Time mode as a simple solution.

Also, in the Time Mode, the seconds ring, 0-60 seconds, starts at the bottom (6-o’clock position) and works it’s way round 360deg! This is a bit odd! Should really start at the 12-o’clock position? Maybe this is normal in Australia ? Lol

Hi, thanks, what version do you have now, have you tried the V3.2.20 version?

okeeffm commented 8 months ago

SmallTV Pro - v3.2.14EN

okeeffm commented 8 months ago

Updated to 3.2.20. Time issue seems to be fixed. What do you think about the issue of the seconds starting from the bottom as opposed to the normal top? ![Uploading image.jpg…]()

Yelles commented 8 months ago

I had the same problem, but it corrected itself in the meantime.

okeeffm commented 8 months ago

I thought the issue was fixed with 3.2.20 but I think it might be related to configuring a second location in the weather function. The time issue appears in both the weather function and time function. I had a second location set in a different time zone. So even when looking at my zone, it’s showing time for the other zone (in my case france which are an hour ahead).

Im still monitoring the issue but if you remove the second location code under the weather setting via web server interface, it seems to at least show my time correctly.

GeekMagicClock commented 8 months ago

@okeeffm Thank you, i agree with you, the seconds should start at the top, the time zone of two cities need to be checked again.

GeekMagicClock commented 8 months ago

Hi, I was thinking of removing the feature of two cities, it's difficult to switch between two different timezone to get correct time, few people have reported this bug, so I think few people need this feature, what do you think?
The seconds should start at the top will be fixed in next release.

okeeffm commented 8 months ago

Hi, yes I would agree this is the best solution - keep it simple.Kind regardsMarkSent from my iPhoneOn 21 Oct 2023, at 13:46, GeekMagic @.***> wrote: Hi, I was thinking of removing the feature of two cities, it's difficult to switch between two different timezone to get correct time, few people have reported this bug, so I think few people need this feature, what do you think? The seconds should start at the top will be fixed in next release.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

GeekMagicClock commented 8 months ago

Hi, please update to V3.2.21.

seocrow commented 8 months ago

Does this work for time changes? Clock seems to show wrong time since time change. Can feature be added to tweak time for time changes like +1 , -1 hours.

okeeffm commented 8 months ago

Time handling much better since changes in latest firmware update removing second location in the weather app. However, still not handling daylight saving / British summertime time changes. For example 28th Oct clocks went back one hour but time is still one hour ahead and no way correcting it.

Simplest way to correct this is to allow user configuration of offset in the Time tab of the web UI.

For example now, 30th oct the offset is zero. To handle daylight saving prior to 28th Oct the offset would be 1 hr.

Update needed asap as the time is now incorrect in the U.K.

There are clever coding solutions to handle this automatically but best to keep the solution simple for now at look at this issue in more detail in a future firmware update.

GeekMagicClock commented 8 months ago

Does this work for time changes? Clock seems to show wrong time since time change. Can feature be added to tweak time for time changes like +1 , -1 hours.

Hi, which city?

GeekMagicClock commented 8 months ago

Time handling much better since changes in latest firmware update removing second location in the weather app. However, still not handling daylight saving / British summertime time changes. For example 28th Oct clocks went back one hour but time is still one hour ahead and no way correcting it.

Simplest way to correct this is to allow user configuration of offset in the Time tab of the web UI.

For example now, 30th oct the offset is zero. To handle daylight saving prior to 28th Oct the offset would be 1 hr.

Update needed asap as the time is now incorrect in the U.K.

There are clever coding solutions to handle this automatically but best to keep the solution simple for now at look at this issue in more detail in a future firmware update.

I'll check it, London, UK ?

seocrow commented 8 months ago

Does this work for time changes? Clock seems to show wrong time since time change. Can feature be added to tweak time for time changes like +1 , -1 hours.

Hi, which city?

All zones in UK affected I believe.

okeeffm commented 8 months ago

Hi,Location is U.K. / London.When daylight saving is not in use, time is GMT + 0. When daylight saving is is use, which it was before 28th October for British summertime, it was GMT+1.Yes If you allow the clock to be adjusted to 0 (no daylight saving) ,+1 (daylight saving) then the user can make this adjustment via the UI.Normal time configuration: - Time-zone - GMT plus 1,2,3,4 etc- Daylight Saving, above plus 1 (clocks forward) or zero (clocks go back to just GMT time zone.You can send me updated firmware - happy to test for you.RegardsMarkSent from my iPhoneOn 1 Nov 2023, at 11:14, GeekMagic @.***> wrote:

Does this work for time changes? Clock seems to show wrong time since time change. Can feature be added to tweak time for time changes like +1 , -1 hours.

Hi, which city?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

okeeffm commented 8 months ago

P.s U.K. only has 1 time zone.  Other large countries can a a few.  Daylight saving adjustments are used in over 30 countries.All these 30 countries adjust forward and back by just 1 hour.MarkSent from my iPhoneOn 1 Nov 2023, at 11:14, GeekMagic @.***> wrote:

Does this work for time changes? Clock seems to show wrong time since time change. Can feature be added to tweak time for time changes like +1 , -1 hours.

Hi, which city?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

GeekMagicClock commented 8 months ago

Thank you for the info, but it should be automatically adjusted according to the city's timezone, manully adjust time offset is the last choice, let the clock do the job. I'll dig into this to see what's going on.

okeeffm commented 8 months ago

I’ve noticed this morning that the clock time was still one hour ahead when in clock mode.  I switched over to weather mode and time is correct - I don’t use the weather mode.

I then switched back to the clock mode and the time is now corrected!  Even after rebooting the time is wrong prior to doing this.

 Based on what you said in your last message re city time zone, does the weather mode code set the time for the device? Do you have to go into weather mode to reset the time and therefore clock mode is corrected also?