search

Gemba / skyscraper

Powerful and versatile game data scraper written in Qt and C++.
https://gemba.github.io/skyscraper/
GNU General Public License v3.0
56 stars 14 forks source link

Docker Image #30

Closed maxexcloo closed 8 months ago

maxexcloo commented 9 months ago

Wondering if it would be possible to use a GitHub action to build the Docker container in an automated fashion (similar to the image I attempted here).

Awesome work BTW, appreciate the revival!

Gemba commented 9 months ago

As Skyscraper builds on Windows, Linux and Mac, what is the added value of a Docker container?

Anyhow, can you elaborate this to an PR? Most likely a docker user don't want to have the Skyscraper input/output trapped into the container, I assume some -v option on docker is to be used to have input provided to Skyscraper from the host and have Skyscraper output land on the host.

maxexcloo commented 9 months ago

I prefer not to install as many packages if I can help it - and this allows for repeatable usage across environments (have been using my container for everything to good results). Happy to raise a PR, my Dockerfile is a bit opinionated I guess so I'll think about how best to update it.