Closed pandino closed 7 months ago
Gemba
commented
9 months ago Thanks. However, that should be held in a separate ES frontend, the current emulationstation.cpp is geared towards Aloshi's release respective the RetroPie's ES. There will be such new frontend nevertheless, once #42 is implemented.
pandino
commented
9 months ago It seems that I actually have the opposite requirement from @maxexcloo: he would like to remove tags and I would like to add them. The ES-DE fork decided to remove the media tags in their implementation, but the folder structure is already compatible with Skyscraper emulationstation frontend (so emulationstation.cpp is technically already compatible with ES-DE...). Other forks went with the more "traditional" approach and added a manual child to the game entry in the gamelist.xml (for example JELOS ).
In my case I use both ES-DE and JELOS and I would like to have a centralized scraper working from the Linux command line.
As a proof of concept I moved my changes to a new frontend in my PR. Not a C++ dev so, just a proof of concept to see if this is the right approach...
Gemba
commented
7 months ago Hi @pandino thanks for paving the way with your initial PR. I took it from there and created #60.
ES-DE support works well for me @leonstyhre, you may also verify the ES-DE manual scraping on your side.
Few frontends support viewing PDF manuals directly from the UI (for example the Emulation Station Desktop and the EmulationStation fork used by Ambernic devices). The ScreenScraper site is also hosting PDFs and for each game, the link to the manual is available from the response json in the section "medias", as type "manuel". It would be nice if skyscraper could support scraping game manuals.
I created a fork and implemented the feature (PR to follow). For the most part I just copied the logic used for the video, if somebody wants to do something more refined is welcome to ignore my PR.