Closed retrobit closed 8 months ago
I apologize about the commit message getting muddled due to rebasing; I will edit it when possible and make sure to modify them correctly during rebases in the future 😀
Fixed commit message, rebased onto master
resolving one debug newline statement in mobygames.cpp
Let me know if you have any questions when reviewing this PR. I noticed it's easier to read the changes with the "Hide whitespace" option, especially for a file like openretro.cpp
:
Absolutely! Apologies for the wait, life happened. I will work on it as soon as I can!
OK the changes should have been reverted/made. Thank you so much for creating the test files... That's huge. I have no experience writing tests using the Qt framework, so I'm looking at them now and learning a lot.
Thanks for this and your endurance and patience.
aliasMap.csv
to Screenscraper, ArcadeDB ("direct match", e.g. filename/hash) scraping modules, except for "local/utility" scrapers, like import or EmulationStation Game List scrapersdirectMatchScrapers
,searchMatchScrapers
, andvariableScrapers
toscraperworker.h
, representing all supported scraper modulesaliasMap.csv
comments to be more clear and follow new behaviorbaseName
to accurately represent strings they represent, for clarity, instead of recycling the same nameQFileInfo.completeBaseName()
andQFileInfo.baseName()
ambiguously. I checked DB APIs behavior/expectations here and made sure to correct/make these consistent with what's expected