Gemba / skyscraper

Powerful and versatile game data scraper written in Qt and C++.
https://gemba.github.io/skyscraper/
GNU General Public License v3.0
56 stars 14 forks source link

Feature - "Direct match" scraper module support for aliasMap.csv #45

Closed retrobit closed 8 months ago

retrobit commented 9 months ago
retrobit commented 9 months ago

I apologize about the commit message getting muddled due to rebasing; I will edit it when possible and make sure to modify them correctly during rebases in the future 😀

retrobit commented 9 months ago

Fixed commit message, rebased onto master resolving one debug newline statement in mobygames.cpp

retrobit commented 9 months ago

Let me know if you have any questions when reviewing this PR. I noticed it's easier to read the changes with the "Hide whitespace" option, especially for a file like openretro.cpp:

Screenshot 2024-03-09 at 12 59 29 PM

retrobit commented 8 months ago

Absolutely! Apologies for the wait, life happened. I will work on it as soon as I can!

retrobit commented 8 months ago

OK the changes should have been reverted/made. Thank you so much for creating the test files... That's huge. I have no experience writing tests using the Qt framework, so I'm looking at them now and learning a lot.

Gemba commented 8 months ago

Thanks for this and your endurance and patience.