Number sequences over time bar chart

GenSpectrum / dashboard-components

https://genspectrum.github.io/dashboard-components/

GNU Affero General Public License v3.0

2 stars 0 forks source link

Number sequences over time bar chart #332

Closed fengelniederhammer closed 4 months ago

fengelniederhammer commented 5 months ago

resolves #316

Summary

Add the bar chart. We'll add the logarithmic scale in #333

Screenshot

PR Checklist

[x] All necessary documentation has been adapted.
[x] The implemented feature is covered by an appropriate test.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 15, 2024 8:43am

github-actions[bot] commented 5 months ago

This is a preview of the changelog of the next release:

0.5.5 (2024-07-15)

Features

components: add new component that shows the number of sequences over time (32f4dcd), closes #327
components: number of sequences over time: compute data (ccd27d6), closes #327
components: number of sequences over time: implement bar chart view (39def2e), closes #316
components: number of sequences over time: implement table view (b52021a), closes #318

fengelniederhammer commented 4 months ago

We decided that we don't implement error bars in this diagram (yet).

chaoran-chen commented 4 months ago

@JonasKellerer, how would you envision an error bar? :)

JonasKellerer commented 4 months ago

The errorbar depends on what we want to display. If we want to display a "measurement" we should include one, since all measurements are bound to have uncertainties. In this case I think of statistical uncertainty, so the user knows that there are only few measurements, but due to statistical fluctuations there could also be different values. This is important to see trends in the data and not mistake some outlier for "real". I think this is what we have done in prevalence over time. However, if we only want to provide the raw data, then no errorbar is needed.