search

GenomicMedLab / cool-seq-tool

https://coolseqtool.readthedocs.io
MIT License
4 stars 0 forks source link

test: update tests for `ExonGenomicCoordsMapper` #364

Closed korikuzma closed 2 months ago

korikuzma commented 3 months ago
jsstevenson commented 3 months ago

create tests for private methods

is this necessary? ostensibly the only behavior that matters is what's public -- is there something that our public method tests aren't capturing? I worry about creating redundant tests that we then have to do twice the work to maintain in the future

korikuzma commented 3 months ago

create tests for private methods

is this necessary? ostensibly the only behavior that matters is what's public -- is there something that our public method tests aren't capturing? I worry about creating redundant tests that we then have to do twice the work to maintain in the future

@jsstevenson There are definitely pros/cons to testing private methods. This was a good exercise for me to better understand the codebase, think of edge cases, and see if private methods needed to be changed. I can change to only test public methods!

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

korikuzma commented 2 months ago

Closing for now until I can come back to this