GeoNet / help

An issues repo for technical help questions.
6 stars 3 forks source link

location code change #89

Closed elidana closed 2 years ago

elidana commented 2 years ago

Hi,

this is a first draft of the communication around Strong Motion Location code change.

The update is:

This pull request also contains a placeholder (component-name.md) for other changes in the seismic data. This still need to be worked on.

Happy to receive any feedback!

Thanks

salichon commented 2 years ago

Hello @elidana this draft is looking good for a start thanks a lot. As much as possible we should add a time tag for each change which gives the date it was implemented in the archive. (as the "version" in the AWS) cheers! jerome

elidana commented 2 years ago

Hi @mnaguit and @salichon , thanks for your review!

@salichon will try my best to add the time when change was applied, though if we are applying all changes within 2-3 months, can we just say that?

elidana commented 2 years ago
elidana commented 2 years ago

Hi @mnaguit @salichon @rumachan , are we happy to merge this one (possibly without the "component change one, that I can strip out and add in a second pull request) or do you think we need to apply other changes? Thanks!!

rumachan commented 2 years ago

Yep, lets make progress and add other stuff later if needed.

elidana commented 2 years ago

Thanks all, I have tidy up this pr, and added all your comments (hopefully). Can I please have one thumbs up, so this one can be merged? Thanks a lot!

salichon commented 2 years ago

@elidana as Steve about merging "Yep, lets make progress and add other stuff later if needed."

so that we can finalize the recent archive update

elidana commented 2 years ago

thanks @salichon !

Merging this one, and will add the remaining comments in the next update