search

GeoNodeUserGroup-DE / contrib_datapackage

A geonode-importer handler to upload non-spatial data as datapackage
GNU General Public License v3.0
1 stars 0 forks source link

After changing metadata of nonSpatial Dataset its converted to geo Dataset #4

Closed mwallschlaeger closed 1 month ago

mwallschlaeger commented 1 year ago

When uploading a dataset as non spatial dataset and editing the metadata of the dataset. The dataset is converted to a spatial dataset

gannebamm commented 1 year ago

@ridoo @matthesrieke please check if this is still valid

ridoo commented 1 year ago

@gannebamm I expected such tickets to appear here: https://github.com/orgs/GeoNodeUserGroup-DE/projects/1/views/4

I will have a look at them once everything from 4.1.0 has been merged, and will add bugfixes if the issue is still valid

ridoo commented 1 year ago

Investigation result: The non-spatial dataset is not converted to a spatial one. The link back to the dataset is using the /dataset route instead using the /tabular one. The metadata editor seems to be using the old Django templates.

ridoo commented 1 year ago

Correction .. it is indeed converted to spatial-dataset, The /tabular route works for normal /datasets so it appeared to me to be a routing issue on the first glimpse. I will have a deeper look.

ridoo commented 1 year ago

The issue is caused by the default resource_manager which is called from layers/views.py#dataset_metadata. The non-spatial importer handler creates a custom resource manager by intent, to avoid conflicting steps when GeoNode tries to sync/handle spatial resources at GeoServer (tiles, styles, gwc, ..).

@gannebamm @matthesrieke It seems that the metadata editor was not tested thoroughly (at least by me), and turns out to be a blind spot for further integration issues.

ridoo commented 8 months ago

I tried to transfer this issue to the GeoNodeUserGroup-DE/importer-datapackage repository where it actually belongs to IMHO, but I only get three private repos as an option:

image

Do anyone know the trick to do so?

gannebamm commented 8 months ago

https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

Note: You can only transfer issues between repositories owned by the same user or organization account. A private repository issue cannot be transferred to a public repository.

Maybe switching this repo to public for transferring the issue could do the trick. Afterwards, it should be put to private again.

gannebamm commented 8 months ago

https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

Note: You can only transfer issues between repositories owned by the same user or organization account. A private repository issue cannot be transferred to a public repository.

Maybe switching this repo to public for transferring the issue could do the trick. Afterwards, it should be put to private again.

I tested that workaround successfully. I am not sure if there are any ramifications by doing that for a 'live' repo. Any ideas?

ridoo commented 8 months ago

I cannot see any ramifications documented under Transferring an issue to another repository which I would reject.

ridoo commented 8 months ago

However, there are side-effects when making private -> public -> private but I cannot spot any, which would raise other issues.

ridoo commented 8 months ago

Note: I have hidden off-topic comments with regard transferring the issues to this repository