Closed lucaperju closed 3 months ago
Hi @lucaperju! This is a really high quality PR! Thanks a lot!
Attention: Patch coverage is 75.23810%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 57.32%. Comparing base (
d424f3e
) to head (fe5641d
).
Files | Patch % | Lines |
---|---|---|
...random_walks/uniform_accelerated_billiard_walk.hpp | 74.69% | 4 Missing and 17 partials :warning: |
include/convex_bodies/hpolytope.h | 77.27% | 0 Missing and 5 partials :warning: |
optimized the complexity of the reflection when the A matrix is sparse
Sampled 1000 points from the same order polytope with the same seed using both sparse and dense abw, here are the last 2 points: Dense: 0.947133 0.13444 0.417853 0.499325 0.995814 0.775422 0.728527 0.715522 0.0377974 0.428896 0.708553 0.119995 0.224509 0.549352 0.919391 0.649939 0.648627 0.55607 0.0863634 0.500581
Sparse: 0.947133 0.13444 0.417853 0.499325 0.995814 0.775422 0.728527 0.715522 0.0377974 0.428896 0.708553 0.119995 0.224509 0.549352 0.919391 0.649939 0.648627 0.55607 0.0863634 0.500581
points_sparse.txt points_dense.txt