search

Georgetown-IR-Lab / cedr

Code for CEDR: Contextualized Embeddings for Document Ranking, accepted at SIGIR 2019.
MIT License
156 stars 28 forks source link

pip compatible #27

Closed seanmacavaney closed 4 years ago

seanmacavaney commented 4 years ago

Quick and easy. Should address #26

@cmacdonald does this meet your needs

cmacdonald commented 4 years ago

Thanks. Pip didnt seem to pickup the dependencies when installing from git. Perhaps you need to list them explicitly in setup.py?

Test case in https://colab.research.google.com/drive/1Zeu7wnj7gtz_lPl_ZjM8PXv3fublJxfA?usp=sharing

seanmacavaney commented 4 years ago

Ah, right. This should take care of the requirements now.

cmacdonald commented 4 years ago

I added a PR on your forked copy - can you unset the tqdm version, then it is good to go!