Fixes some HarvestCommand logging - Githubissues

GetDKAN / dkan

DKAN Open Data Portal

https://dkan.readthedocs.io/en/latest/index.html

GNU General Public License v2.0

374 stars 172 forks source link

Fixes some HarvestCommand logging #4269

Closed paul-m closed 2 months ago

paul-m commented 3 months ago

Fixes [issue#]

Describe your changes

Removes logger as an injected dependency from HarvestCommands.
Converts all commands in HarvestCommands to use $this->logger() instead of alternatives.
Converts all message strings to use concatenation rather than interpolation.
Adds minimal automated test of commands.

QA Steps

Use sample_content module to create a harvest.

Try out the commands.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

[ ] I have updated or added tests to cover my code
[ ] I have updated or added documentation