search

GetFirefly / firefly

An alternative BEAM implementation, designed for WebAssembly
Apache License 2.0
3.61k stars 103 forks source link

Source spans cannot start and end in different files #597

Open KronicDeth opened 3 years ago

KronicDeth commented 3 years ago

416 files in lumen/otp fail to compile because of Source spans cannot start and end in different files.

Affects the following files in OTP:

hansihe commented 3 years ago

Pretty sure I have a fix for this, but can you point me to a specific file that fails so I can check?

KronicDeth commented 3 years ago

The first one is erts/preloaded/src/atomics.erl

You can find all the failing files by checking the lumen-otp builds for either macOS or Linux in the "Test compiling lumen/otp against liblumen_otp" like here. You could also download the raw log since the GUI is all scrollbar-y and hard to read for how long ours is.

hansihe commented 3 years ago

This should be fixed for the vast majority of cases, but there are still cases where it can happen. Will leave this issue open until the issue is 100% solved.

https://github.com/eirproject/eir/commit/0cf790fc713fafbfa36b63e75ccac20d37916320

KronicDeth commented 3 years ago

The new list after https://github.com/eirproject/eir/commit/0cf790fc713fafbfa36b63e75ccac20d37916320: