GetFirefly / firefly

An alternative BEAM implementation, designed for WebAssembly
Apache License 2.0
3.61k stars 105 forks source link

-compile(inline) is not supported #635

Closed KronicDeth closed 4 years ago

KronicDeth commented 4 years ago

I don't think we necessarily need to do the inlining it wants, we just need for EIR to parse it and maybe keep track that the flag is on to use later, but I kinda feel that Erlang-level inlining decisions have different performance and code size trade offs than native compiling with lumen, so it is probably best to ignore it for now.

warning: invalid compile option
    ┌─ /Users/runner/work/lumen/otp/lib/kernel/src/user.erl:21:10
    │
 21 │ -compile(inline).
    │          ^^^^^^ this option is either unsupported or unrecognized

Affects the following files in OTP:

hansihe commented 4 years ago

Fixed by https://github.com/eirproject/eir/commit/2a89b9c03df60176e3fa9c0966abe287a4422195

KronicDeth commented 4 years ago

Confirmed fixed.