search

GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

fix(components-native): Restore success Text variation type #2059

Closed jdeichert closed 1 month ago

jdeichert commented 1 month ago

Motivations

Two cases of Text in JM use variation=success with reverseTheme=true and that results in the successReverse color being used which is --color-success. We don't yet have another variation that matches that color, so we need to add this back for now to unblock the JM version bump PR.

Changes

Fixed

Testing

See my comment with before/after screenshots below.

In Storybook, load the Text Basic story, set variation=success and reverseTheme=true. The text should appear green and match --color-success.

Changes can be tested via Pre-release

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a54c87
Status: âœ…  Deploy successful!
Preview URL: https://c574834f.atlantis.pages.dev
Branch Preview URL: https://cleanup-add-back-success-tex.atlantis.pages.dev

View logs