fix(components-native): Assistive text alignment on `Select`

GetJobber / atlantis

🔱 Atlantis

https://atlantis.getjobber.com

MIT License

27 stars 30 forks source link

fix(components-native): Assistive text alignment on `Select` #2068

Closed jjwlee94 closed 1 month ago

jjwlee94 commented 1 month ago

Motivations

Assistive text is misaligned on Select.

Changes

Added

Changed

Deprecated

Removed

Fixed

Added left padding to the assistive text.

Before	After

Security

Testing

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`db252b5`
Status:	✅ Deploy successful!
Preview URL:	https://2972a8cb.atlantis.pages.dev
Branch Preview URL:	https://assistive-text-alignment.atlantis.pages.dev

View logs

MichaelParadis commented 1 month ago

Following up on @chris-at-jobber 's comment this can likely be done by remove the "old" assistive text rendering logic and passing the prop as the assistiveText prop for the InputFieldWrapper

jjwlee94 commented 1 month ago

Following up on @chris-at-jobber 's comment this can likely be done by remove the "old" assistive text rendering logic and passing the prop as the assistiveText prop for the InputFieldWrapper

I've removed the assistiveText and passed it through InputFieldWrapper