GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(components): Update apple icon and Add bank icon [JOB-106774] #2073

Closed youre-jobber closed 1 month ago

youre-jobber commented 1 month ago

Motivations

Changes

Added

This icon:

Changed

This icon:

Testing

https://github.com/GetJobber/atlantis/actions/runs/11352845839


In Atlantis we use Github's built in pull request reviews.

Aquamen opening a new bank account

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 686f1b9
Status: ✅  Deploy successful!
Preview URL: https://be0f447e.atlantis.pages.dev
Branch Preview URL: https://job-106774-svg-for-apple-ico.atlantis.pages.dev

View logs

github-actions[bot] commented 1 month ago

Published Pre-release for 71f50e6a5845d37b5015960fdbc1dfb8df5993f9 with versions:

  - @jobber/components@5.40.4-JOB-106774-71f50e6.2+71f50e6a

To install the new version(s) for Web run:

npm install @jobber/components@5.40.4-JOB-106774-71f50e6.2+71f50e6a
MichaelParadis commented 1 month ago

@youre-jobber

  1. The change log will be updated automatically.
  2. I think the height and width should be set since it isn't set on any of our other icons. Did you follow the exporting of the SVG guide called in "Contributor Guide: Adding an icon to Atlantis" in our confluence?
  3. Since Bank is a new icon I think it should live in the payments section instead of the Legacy section https://job-106774-svg-for-apple-ico.atlantis.pages.dev/?path=/docs/components-images-and-icons-icon--docs#legacy

CC: @chris-at-jobber

youre-jobber commented 1 month ago

@MichaelParadis, the designer (David) gave me the icon, so I can double-check with him...

MichaelParadis commented 1 month ago

@youre-jobber I chatted with @chris-at-jobber and you should be good. You will need to update some snapshots with npm run test -- -u