Closed nad182 closed 1 week ago
Latest commit: |
5efc034
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e697a9a6.atlantis.pages.dev |
Branch Preview URL: | https://job-109113-remove-userefocus.atlantis.pages.dev |
Could not publish Pre-release for 5efc0349489e168490fe42d9e9b2fd115f65016e. View Logs
The problem is likely in the NPM Publish
or NPM CI
step in the Trigger Pre-release Build
Job.
Previous build information:
Published Pre-release for 5efc0349489e168490fe42d9e9b2fd115f65016e with versions:
- @jobber/design@0.67.3-JOB-109113-5efc034.11+5efc0349
To install the new version(s) for Web run:
npm install @jobber/design@0.67.3-JOB-109113-5efc034.11+5efc0349
To install the new version(s) for Mobile run:
npm install @jobber/design@0.67.3-JOB-109113-5efc034.11+5efc0349 ```. For more troubleshooting steps, see the [Pre-release Troubleshooting Guide](https://jobber.atlassian.net/wiki/x/dQFhnw)
Motivations
The video of the issue can be found here: https://jobber.atlassian.net/browse/JOB-108034
Basically, navigating to Home from Requests tab (where DataList -> DataListHeaderTile is instantiated) caused Requests nav link item to refocus, making it appear as if this is still an active link.
While investigating the issue, I noticed that the
useRefocusOnActivator
hook was called twice, once inDataListSortingOptions
(to move focus back onto the column header after the sorting option was selected with an assistive technology/keyboard) and inDataListHeaderTile
(where I believe it should NOT be called). So this PR removes calling this hook inDataListHeaderTile
.Changes
Added
Changed
Deprecated
Removed
visible
prop fromDataListHeaderTile
useRefocusOnActivator
hook call inDataListHeaderTile
Fixed
Security
Testing
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.