GetStream / stream-chat-react-native

๐Ÿ’ฌ React-Native Chat SDK โžœ Stream Chat. Includes a tutorial on building your own chat app experience using React-Native, React-Navigation and Stream
https://getstream.io/chat/sdk/react-native/
Other
981 stars 325 forks source link

fix: android poll creation modal size #2783

Closed isekovanic closed 2 weeks ago

isekovanic commented 2 weeks ago

๐ŸŽฏ Goal

It appears that on version 0.76.0 of React Native and onwards Android modals are known to bug out if it is not immediately clear what the size of their parent is, even if it's enclosed and completely predictable. It's not entirely clear to me (yet) if this is a new architecture thing or something else. The change makes sure that the Modal's immediate parent is correct and signals the Android internals to properly calculate the size of the modal.

Special styling overrides to the modal are not given because:

๐Ÿ›  Implementation details

๐ŸŽจ UI Changes

iOS
Before After
Android
Before After

๐Ÿงช Testing

โ˜‘๏ธ Checklist

isekovanic commented 2 weeks ago

Shall we backport this to v5 as well? There may be customers using 0.76 without new arch enabled.

We can, yes - it's a small change so no biggie