GetStream / vg

Virtualgo: Easy and powerful workspace based development for go
MIT License
1.32k stars 45 forks source link

Changing workspace breaks fish shell #40

Open karlek opened 6 years ago

karlek commented 6 years ago

When changing from one workspace to another in fish, the prompt updating fails. It's worth noting that I've have a function in my fish config also called fish_prompt:

https://github.com/karlek/dotfiles/blob/master/.config/fish/conf.d/08-prompt.fish

(gateway) (^._.^)ノ elysium @ /home/_/.local/share/go/src/github.com/karlek/tf/gateway $ ../keysmith/
Deactivating gateway
functions: Function “fish_prompt” already exists. Cannot create copy “_old_fish_prompt”
- (line 109): 
        functions -c _old_fish_prompt fish_prompt
        ^
in function “_vg_deactivate”
    called on line 46 of file -

in function “_vg_activate”
    called on line 13 of file -
    with parameter list “activate keysmith”

in function “vg”
    called on line 189 of file -
    with parameter list “activate keysmith”

in function “__vg_auto_activate”
    called on line 5 of file /usr/share/fish/functions/cd.fish
    with parameter list “VARIABLE SET PWD”

in event handler: handler for variable “PWD”

       functionsfunctions - print or erase functions
        -

   Synopsis
       functions [ -a | --all ] [ -n | --names ]
       functions [ -D | --details ] [ -v ] FUNCTION
       functions -c OLDNAME NEWNAME
       functions -d DESCRIPTION FUNCTION
       functions [ -e | -q ] FUNCTIONS...

functions: Type “help functions” for related documentation

Activating keysmith
(keysmith) _@elysium ~/.l/s/g/s/g/k/t/keysmith>
JelteF commented 6 years ago

Hmm that's definitely a bug, if you want to create a PR to fix this that would be appreciated. Otherwise I'll try to fix it in the near future. For now you can probably work around this by setting the following in your config.fish file:

export VIRTUALGO_DISABLE_PROMPT=true

Then you can use the $VIRTUALGO environment variable in your own prompt to display it however you like.