search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.72k stars 676 forks source link

Can't boost with Firework when flying with Elytra in 1.12.2 creative #2904

Open pinkpig58 opened 2 years ago

pinkpig58 commented 2 years ago

Describe the bug

When flying with the elytra, I'm unable to use the firework to boost myself forwards.

To Reproduce

  1. Put on an Elytra and grab some fireworks
  2. Start flying with the Elytra
  3. Attempt to use the fireworks (I use right-click)

Expected behaviour

When using the fireworks, it should boost you forwards.

Screenshots / Videos

https://user-images.githubusercontent.com/41856020/160236630-56900a1a-7094-4f12-a26a-82db5459b30b.mp4

Server Version and Plugins

CraftBukkit version git-Spigot-79a30d7-f4830a1 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Plugins (3): ViaVersion, floodgate, Geyser-Spigot

Geyser Dump

https://dump.geysermc.org/Qg9E2Gh4QTUfBPZ2Jg7tGytXH997GUrL

Geyser Version

2.0.2-SNAPSHOT (git-master-238be40)

Minecraft: Bedrock Edition Version

1.18.12

Additional Context

No response

rtm516 commented 2 years ago

Have you tried when not in creative?

(For anyone reading this on the dev team, we did add support but likely if confirmed there was a regression somewhere, see https://github.com/GeyserMC/Geyser/pull/552)

Camotoy commented 2 years ago

Confirmed in 1.12.2. 1.18.2 is fine though.

Camotoy commented 2 years ago

The core issue is, actually, that 1.12 never recognizes the player is gliding. And it does appear fine on survival.

pinkpig58 commented 2 years ago

I can't seem to get it working in survival, either

https://user-images.githubusercontent.com/41856020/160245050-b2b4639c-d1be-49d9-aa39-e2c7a9e0fb85.mp4

Camotoy commented 2 years ago

Try starting not from creative flying (switch to survival, place some blocks up, then glide).

pinkpig58 commented 2 years ago

Like this?

https://user-images.githubusercontent.com/41856020/160245312-30e683dd-0210-4513-987a-2ab7dc0a5398.mp4

Camotoy commented 2 years ago

Yes, that would be it.

Camotoy commented 2 years ago

I took a look, but I'm not sure if I can go further at the moment. The issue is that this check: this.player.motY < 0.0D fails when we send the glide start packet, at least on creative (your survival has fireworks spawning, so that may be a different issue but I'm unable to replicate it).

onebeastchris commented 1 year ago

with dropped 1.12.2 support, does this even need fixing?

Camotoy commented 1 year ago

I still see this as a valid issue, as Geyser-Standalone still exists.