GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.7k stars 673 forks source link

Npc no work left click [Citizens] #4087

Closed GreatGoal0 closed 9 months ago

GreatGoal0 commented 1 year ago

Describe the bug

An npc with an action left clicking the npc runs a command and this doesn't work on Bedrock, only right clicks work (you must press the npc for 3 seconds to execute the action)

To Reproduce

  1. /ncp create NameNpc
  2. /npc select (looking at the npc)
  3. /npc cmd add -p -l -r spawn (-l = left click and -r = right click)
  4. Click only once on the npc (left click) and it does not execute the command

Expected behaviour

Just click the npc once and have him execute the command

Screenshots / Videos

No response

Server Version and Plugins

Plugins: BankPlus, BedrockFormShop, BuycraftX, ChatManager, ConditionalEvents, CrazyVouchers, CrossplatForms, DecentHolograms, DeluxeMenus, ExcellentCrates, Citizens, FastAsyncWorldEdit, floodgate, Geyser-Spigot, GeyserUpdater, LuckPerms, MasterCooldowns, Multiverse-Core, MyCommand, NexEngine, PlaceholderAPI, PlayerKits, ProtocolLib, ServerVariables, spark, SternalBoard, TAB, Themis, Triton, Vault, VoidGen, WorldBorder, WorldGuard, XConomy

Versión: Current: git-Purpur-2045 (MC: 1.20.1)*

Geyser Dump

https://dump.geysermc.org/Ij4ohvZiv2F63kCnaPRFDL53a87ui2aI

Geyser Version

Geyser version 2.2.0-SNAPSHOT (git-master-35a8e15) (Java: 1.20, Bedrock: 1.19.80/1.19.81 - 1.20.10)

Minecraft: Bedrock Edition Device/Version

Móvil Andorid

Additional Context

No response

GreatGoal0 commented 1 year ago

Fix?

Jens-Co commented 1 year ago

Bumping issues will not speed up the process. Please be patient until we get around this, thanks.

onebeastchris commented 10 months ago

Unable to reproduce using 1.20.40, the latest version of Geyser (#348 at the time of writing), and a Citizens NPC created with the following command:

onebeastchris commented 9 months ago

Closing due to no response. If this still an issue, create a new post with exact reproduction steps.

GreatGoal0 commented 7 months ago

Hello, the left click is the one that does not work on Android, sorry, I just saw this

GreatGoal0 commented 7 months ago
  1. /npc create test
  2. /npc select
  3. /npc cmd add -p help -l and /npc cmd add -p help -r

Left click: If I press/hit the npc nothing happens, if I hold down the npc nothing happens Right click: If you pressed/hit the npc once nothing happens, if I let you press the npc it executed the /help command

What I hope will happen is that when the npc receives a left click (-l) command when pressing/hitting the npc once (do not hold down) the command is executed correctly, in the case of right click I think it is working correctly

https://mclo.gs/UpgYVFj Screenshot_2024-01-29-03-50-45-28_e4424258c8b8649f6e67d283a50a2cbc Screenshot_2024-01-29-03-22-51-54_e4424258c8b8649f6e67d283a50a2cbc

onebeastchris commented 7 months ago

Still unable to replicate. Using latest version of citizens (currently, at the time of writing, build 3312), and running the commands you provided works just fine for me.

To ensure both left and right click work, i've created two npc's during my testing.

Right click:

[10:49:40 INFO]: .onebeastofchris issued server command: /npc create test
[10:49:56 INFO]: .onebeastofchris issued server command: /npc select
[10:50:39 INFO]: .onebeastofchris issued server command: /npc cmd add -p help -r
[10:50:40 INFO]: .onebeastofchris issued server command: /help

Left click:

[10:53:39 INFO]: .onebeastofchris issued server command: /npc create testq
[10:53:45 INFO]: .onebeastofchris issued server command: /npc select
[10:54:08 INFO]: .onebeastofchris issued server command: /npc cmd add -p help -l
[10:54:09 INFO]: .onebeastofchris issued server command: /help

Tested on both 1.20.51 Windows edition and Android, both work fine for me. This is on a clean 1.20.4 paper server, with only Geyser, Floodgate and Citizens installed.

GreatGoal0 commented 7 months ago

Does the npc with left click command (-l) when hitting only once execute the /help command in this case?

GreatGoal0 commented 7 months ago

Even though I updated citizens and purpur and deleted all the plugins, I have to stop pressing the npc with left click cmd (-l)

onebeastchris commented 7 months ago

Does the npc with left click command (-l) when hitting only once execute the /help command in this case?

Yes.

At this point I'd honestly recommend to try and use a 1.20.4 paper server with just Geyser, Floodgate and citizens installed on it. If that still doesn't work there, please share an IP/port I can join to test it out

GreatGoal0 commented 7 months ago

You were right my dear, using paper works

GreatGoal0 commented 7 months ago

Well, I updated my normal server to paper but it doesn't work, could it be a plugin that is affecting it?

onebeastchris commented 7 months ago

Seems like it, since it does work on a clean paper server. That's on you to figure out though - you can use the steps below to do so.

If you have a possible plugin interfering with Geyser or Floodgate, follow these steps to find the culprit plugin: Temporarily remove/move half of your plugins from your server's plugins folder.

Keep repeating this pattern, this time with the half that exhibits the problem, until you find your problematic plugin.

GreatGoal0 commented 7 months ago

Is there a possibility that this will fail for the world? I just created a new world and npc and this one works

GreatGoal0 commented 7 months ago

Do you want to go in and see it? It is on my normal server

onebeastchris commented 7 months ago

That won't be necessary. Since the issue does not occur on a clean 1.20.4 paper server, this is an incompatibility with some other plugin - i doubt that the world itself would prevent it.

GreatGoal0 commented 7 months ago

Believe me, it's the world, I can give you the IP so you can see

GreatGoal0 commented 7 months ago

On the same server that fails I made a new world and moved the npc, in the new world it works and in the other it doesn't