search

Ghini / ghini.desktop

plant collections manager (desktop version)
http://ghini.github.io/
GNU General Public License v2.0
24 stars 14 forks source link

XSL formatter manages to crash ghini if no institution data is given #430

Closed mfrasca closed 5 years ago

mfrasca commented 5 years ago

As a graphical environment, I want computing threads not to mix with the GUI, so that the program doesn't crash.

Expected behaviour

threads computing things should only compute things, not also display messages and dialog boxes. when something goes wrong, they should fail with an error condition (an exception), so that the invoking GUI can display the dialog box.

Opinions

unfortunately, much of bauble/ghini is built around this smart and simple fibra thing, implementing collaborative concurrency, and letting the programmer forget about good behaviour. I think we should really get rid of that.

mfrasca commented 5 years ago

I have added a utils.idle_message function, which you can invoke from any thread. it should display 'modal' though.

mfrasca commented 5 years ago

it is modal. :-)