GhostWording / gw-config-apis

this repo contains static json that can live through apis with github management only
0 stars 7 forks source link

Condition issue with Android/Messenger client #30

Open andreasdieryck opened 6 years ago

andreasdieryck commented 6 years ago

@BillyWaveM has created two sequences:

  1. the first sequence (https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/sequences/appspecials/fortnite/FortniteHeard.json) sets a condition ppPlayFortnite (line 91)
  2. the second sequence opens on the "Condition": "ppPlayFortnite == 'true'"

We've put those two sequences in several bots (nuttynow, surveyios, surveyapps, louisjshotbot). Here's what happened when we tried these botnames in the three different clients:

A. On Android

screenshot_20180511-121830

After "Tu y joues", here's what's supposed to happen:

However, after answering "Yes" to "Tu y joues", I don't see sequence 2 on Android ❌

B. On Messenger

screenshot_20180511-122506

Again, after "Do you play it?", here's what's supposed to happen:

However, after answering "Yes" to "Do you play it", I don't see sequence 2 on Messenger❌

C. On iOS

tuyjoues

Again, after "Tu y joues?", here's what's supposed to happen:

This time, sequence 2 is triggered: the condition is working properly with the iOS client ✅

We have made several test to confirm this issue and they all come to the same conclusion: sequence 2 is only triggered on the iOS client, neither on Android nor on Messenger

What do you think about it @rhwy ? How can we help you find the issue?

rhwy commented 6 years ago

for that kind of stuff you absolutely need to do the tests with postman to see what happen in order to first see if the problem is on the server side or the client side.

manually the steps would be:

everything for making these calls is documented here https://github.com/GhostWording/PublicDocumentation/blob/master/API/Sections/SequencesBotApis.md

For me this sounds like android not sending correctly the property. we also have to be sure that the calls are done for all apis with the exact same identifiers {deviceid, facebookid, botname}.

I also had this kind of situation on messenger bots but only when I try to evaluate a condition just after set the property but it was because I was in the same request and the context with the new property didn't refreshed yet from the database. But it's something that can't happend on apis side ;)

rhwy commented 6 years ago

@andreasdieryck could you re-test this after my comment just to confirm we can close the issue ?