search

GioBonvi / GoogleContactsEventsNotifier

Receive automatic email notifications before your Google Contacts birthday and other events!
MIT License
219 stars 50 forks source link

Fix minor issues #160

Closed mstojanovic closed 4 years ago

mstojanovic commented 4 years ago

i have just installed the script to my account and had some minor problems that i had to deal with. i have tried to fix or expand the explanation in the commits im sending for this pull request. Also, someone should maybe take a look to the instructions for enabling contacts calendars to be visible in the google calendar since that also changed. i couldnt do it since my calendars have already been set up before so i cant really say how to do it correctly now

GioBonvi commented 4 years ago

Hi everyone, first of all I'd like to thank you @mstojanovic for spending your time on this with your contributions and @baatochan for the feedback.

It looks like this could be merged with just one or two modifications: I'll leave some comments. I took the liberty to change the base branch from master to development as per the contribution guidelines.